help! upgrading Processor and graphics card

i don’t have made my final choice but i think these are ok…
what do you think?
graphics card : Gigabyte GeForce GTX470 1.3GB
processor : Intel Core i5 680
ps:i have 4gb ram
Answer #1
i don't have made my final choice but i think these are ok...
what do you think?

I think you should specify which motherboard & power supply
do you have.
Answer #2
I really don’t know why anyone would choose that processor over something else considering it’s price
Answer #3
I guess it’s all right but what’s your current processor? there’s a chance your mobo may not support the i5 series. be sure to check!